[webkit-reviews] review granted: [Bug 93308] [chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface : [Attachment 156790] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 6 17:07:10 PDT 2012


James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 93308: [chromium] Convert WebScrollbarThemeGeometry from a concrete class
to an interface
https://bugs.webkit.org/show_bug.cgi?id=93308

Attachment 156790: Patch
https://bugs.webkit.org/attachment.cgi?id=156790&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156790&action=review


> Source/WebCore/platform/chromium/support/WebScrollbarThemeGeometryNative.h:29

> +#include "ScrollbarThemeComposite.h"

mind moving this#include to the .cpp? You don't deref this type in any inline
functions, so a forward decl would work here


More information about the webkit-reviews mailing list