[webkit-reviews] review granted: [Bug 92996] [CSS Regions] region-overflow: break still renders the content that does not fit in the last region. : [Attachment 156526] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 92996: [CSS Regions] region-overflow: break still renders the content that
does not fit in the last region.
https://bugs.webkit.org/show_bug.cgi?id=92996

Attachment 156526: Patch
https://bugs.webkit.org/attachment.cgi?id=156526&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156526&action=review


The change looks fine.

By the way - probably related - but shouldn't RenderBlock::hasNextPage be
changed too? AFAICT we shouldn't have an extra page after the last region if it
has region-overflow: break but the code seems to imply that we do.

> LayoutTests/fast/regions/region-overflow-break-expected.html:15
> +#gray {
>      overflow:visible;
>  }

This doesn't look fine but I guess it is expected because we don't implement
forced region breaking. I would put a FIXME as it's confusing if you don't know
our current implementation.