[webkit-reviews] review granted: [Bug 93147] [Qt] Use GraphicsLayerAnimation in LayerTreeCoordinator : [Attachment 156725] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 93147: [Qt] Use GraphicsLayerAnimation in LayerTreeCoordinator
https://bugs.webkit.org/show_bug.cgi?id=93147

Attachment 156725: Patch
https://bugs.webkit.org/attachment.cgi?id=156725&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156725&action=review


I think this looks fine.

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.
cpp:792
> +    bool hasBigRotation;

shouldnt this be initialized? or is it an ignored value? like
ignoredHasBigRotation;

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.
cpp:818
> +
> +

double newline

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.
h:218
> +
> +

double newline