[webkit-reviews] review denied: [Bug 92724] CSSFontSelector::getFontData() doesn't check font-weight : [Attachment 155700] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 6 11:47:16 PDT 2012


mitz at webkit.org has denied Kenichi Ishibashi <bashi at chromium.org>'s request for
review:
Bug 92724: CSSFontSelector::getFontData() doesn't check font-weight
https://bugs.webkit.org/show_bug.cgi?id=92724

Attachment 155700: Patch
https://bugs.webkit.org/attachment.cgi?id=155700&action=review

------- Additional Comments from mitz at webkit.org
This is still wrong. For example, it breaks this test case:

<style>
    @font-face {
	font-family: custom;
	src: url(file:///Library/Fonts/Herculanum.ttf);
	font-weight: 500;
	unicode-range: U+0060-0061;
    }
    @font-face {
	font-family: custom;
	src: url(file:///Library/Fonts/Zapfino.ttf);
	font-weight: 300;
    }
</style>
<div style="font-family: custom;">ab</div>


More information about the webkit-reviews mailing list