[webkit-reviews] review granted: [Bug 91089] [NRWT] runs platform specific tests that it shouldn't with --force : [Attachment 156718] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 6 10:54:36 PDT 2012
Dirk Pranke <dpranke at chromium.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 91089: [NRWT] runs platform specific tests that it shouldn't with --force
https://bugs.webkit.org/show_bug.cgi?id=91089
Attachment 156718: Patch
https://bugs.webkit.org/attachment.cgi?id=156718&action=review
------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156718&action=review
r+ w/ nits. Feel free to land if you can figure out why the CQ is failing ...
> Tools/Scripts/webkitpy/layout_tests/port/test.py:225
> tests.add('platform/test-snow-leopard/websocket/test.html')
hm ... this is probably a bug, the baseline_search_path() checks for
test-mac-snowleopard but here we have test-snow-leopard. I should fix that.
It might be clearer if we added a test/test-win-win7/http/test.html, since
win-win7 shouldn't be in the path for either mac-leopard or mac-snowleopard.
> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:899
> + # FIXME: we should not rely on knowleadge about the default port.
If you changed line 897 to get_tests_run(['--platform', 'test-mac-leopard',
'http'], ...) you can get rid of the FIXME.
More information about the webkit-reviews
mailing list