[webkit-reviews] review canceled: [Bug 92471] ASSERTION FAILED: allocatedMaxLogicalWidth <= cellMaxLogicalWidth : int WebCore::AutoTableLayout::calcEffectiveLogicalWidth() : [Attachment 156350] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 92471: ASSERTION FAILED: allocatedMaxLogicalWidth <= cellMaxLogicalWidth :
int WebCore::AutoTableLayout::calcEffectiveLogicalWidth()
https://bugs.webkit.org/show_bug.cgi?id=92471

Attachment 156350: Patch
https://bugs.webkit.org/attachment.cgi?id=156350&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156350&action=review


The code change is fine, but this needs a test case.

> Source/WebCore/ChangeLog:11
> +	   Existing tests should cover the changes made in this patch hence not
adding any new tests.

That's not true: the rounding is properly covered by the tests. However we had
no test triggering the ASSERT so you need to add such a test.

> Source/WebCore/rendering/AutoTableLayout.cpp:364
> +		   maxLogicalWidth = max(maxLogicalWidth,
static_cast<int>(max(spanMaxLogicalWidth, cellMaxLogicalWidth) * 100  /
cellLogicalWidth.percent()));

Do we still need this static_cast<int>?