[webkit-reviews] review granted: [Bug 91773] create a MediaSource object : [Attachment 156590] fixing CMakeLists.txt

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 91773: create a MediaSource object
https://bugs.webkit.org/show_bug.cgi?id=91773

Attachment 156590: fixing CMakeLists.txt
https://bugs.webkit.org/attachment.cgi?id=156590&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=156590&action=review


> Source/WebCore/Modules/mediasource/MediaSource.cpp:97
> +    RefPtr<SourceBuffer> buffer =
SourceBuffer::create(String::number(++m_nextSourceBufferId), this);

Does this need to deal with m_nextSourceBufferId wrapping around?

> Source/WebCore/Modules/mediasource/MediaSourceRegistry.cpp:44
> +    ASSERT(isMainThread());

Why is this ASSERT necessary? A comment would be helpful.