[webkit-reviews] review denied: [Bug 93090] Web Inspector: requests filtering in network tab : [Attachment 156685] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Chadnov
<chadnov at google.com>'s request for review:
Bug 93090: Web Inspector: requests filtering in network tab
https://bugs.webkit.org/show_bug.cgi?id=93090

Attachment 156685: Patch
https://bugs.webkit.org/attachment.cgi?id=156685&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156685&action=review


> Source/WebCore/ChangeLog:3
> +	   A new feature added: filtering in the network panel.

This line should be equal to the bug summary.

> Source/WebCore/ChangeLog:5
> +	   Reviewed by NOBODY (OOPS!).

Please add a blank line before this line.

> Source/WebCore/ChangeLog:6
> +

Please add a change description here. See previous changes's ChangeLogs for the
reference

> Source/WebCore/inspector/front-end/FilterController.js:5
> + * modification, are permitted provided that the following conditions are
met: *

Please fix formatting of the license text, there should be new lines before
'*'. It should look the same as in the other files.

> Source/WebCore/inspector/front-end/FilterController.js:33
> +    this._element.cellSpacing = 0;

Please remove this.

> Source/WebCore/inspector/front-end/FilterController.js:35
> +    // Column 1

Please remove these comments.

> Source/WebCore/inspector/front-end/NetworkPanel.js:-754
> -

Please revert this change.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1757
> +	   if (!this._parentView._hiddenCategories.all &&
!this._parentView._filteredOutRequests.get(this._request))

It is enough to look at _filteredOutRequests once.

if (this._parentView._filteredOutRequests.get(this._request))
    return true;
if (!this._parentView._hiddenCategories.all)
    return false;
return this._request.type.name() in this._parentView._hiddenCategories;