[webkit-reviews] review granted: [Bug 93019] Web Inspector: WebInspector.linkifyStringAsFragment gives wrong typeof lineNumber : [Attachment 156403] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 6 06:20:24 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has granted johnjbarton
<johnjbarton at chromium.org>'s request for review:
Bug 93019: Web Inspector: WebInspector.linkifyStringAsFragment gives wrong
typeof lineNumber
https://bugs.webkit.org/show_bug.cgi?id=93019
Attachment 156403: Patch
https://bugs.webkit.org/attachment.cgi?id=156403&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156403&action=review
> Source/WebCore/inspector/front-end/ResourceUtils.js:210
> + lineNumber = parseInt(lineColumnMatch[1]);
Nit: we explicitly say parseInt(foo, 10) to make closure compiler happy.
More information about the webkit-reviews
mailing list