No subject


Wed Aug 1 07:28:53 PDT 2012


- per-inspector progress UI (located in the bottom part of the screen) for
background operations (could be several of these in extreme cases)
- local convenience embeddable progress control bound to the progress
interface.

> Source/WebCore/inspector/front-end/ProgressBar.js:50
> +	* @param {number} worked

number=

> Source/WebCore/inspector/front-end/ProgressBar.js:138
> +	   this._progressElement.value = worked;

worked is a delta, additive value, not absolute (setWorked?).

> Source/WebCore/inspector/front-end/ProgressBar.js:156
> +    this._parent.worked(0);

worked(0) should be a noop.

> Source/WebCore/inspector/front-end/ProgressBar.js:170
> +    createSubProgress: function(weight, totalWork)

Remove totalWork.

> Source/WebCore/inspector/front-end/ProgressBar.js:200
> +    this._parent = parent;

this._composite ?


More information about the webkit-reviews mailing list