[webkit-reviews] review denied: [Bug 92762] Web Inspector: display progress bar while loading timeline data : [Attachment 156425] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 6 06:07:34 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 92762: Web Inspector: display progress bar while loading timeline data
https://bugs.webkit.org/show_bug.cgi?id=92762

Attachment 156425: Patch
https://bugs.webkit.org/attachment.cgi?id=156425&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156425&action=review


Could you split this change into 2: progress indicator + timeline usage?

> Source/WebCore/ChangeLog:12
> +	   - consume contextmenu events in the glass pane;

Seems to be unrelated.

> Source/WebCore/WebCore.gypi:6350
> +	       'inspector/front-end/ProgressBar.js',

Please mind alphabetic order

> Source/WebCore/inspector/front-end/Panel.js:260
> +	   this._progressIndicator = progressIndicator;

I think that progress should not correlate with the glass panel. Timeline
should block its capabilities upon loading on its own.

> Source/WebCore/inspector/front-end/Panel.js:261
> +	  
this._progressIndicator.addEventListener(WebInspector.ProgressIndicator.Events.
Done, this._onProgressIndicatorDone, this);



More information about the webkit-reviews mailing list