[webkit-reviews] review granted: [Bug 93125] [Qt][WK2] Remove workarounds from input event handling : [Attachment 156660] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 6 05:14:59 PDT 2012


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 93125: [Qt][WK2] Remove workarounds from input event handling
https://bugs.webkit.org/show_bug.cgi?id=93125

Attachment 156660: Patch
https://bugs.webkit.org/attachment.cgi?id=156660&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=156660&action=review


Just one nitpick.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1694
> +	   ASSERT(event->type() == QEvent::UngrabMouse);

Maybe I'm not seeing well its purpose but it feels like this might backfire
more often that it would help us. I'm also just a bit tired of asserts popping
in the UI code that you can just comment out without it exposing any real bug.


More information about the webkit-reviews mailing list