[webkit-reviews] review granted: [Bug 93257] Web Inspector: a tiny refactoring of Highlighter in InspectorDOMAgent : [Attachment 156662] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 93257: Web Inspector: a tiny refactoring of Highlighter in
InspectorDOMAgent
https://bugs.webkit.org/show_bug.cgi?id=93257

Attachment 156662: Patch
https://bugs.webkit.org/attachment.cgi?id=156662&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156662&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:1008
> +	   m_inspectModeHighlightConfig =
highlightConfigFromInspectorObject(errorString, highlightInspectorObject);

You should return early in case of error.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1054
> +	   if (highlightConfig)

ditto.