[webkit-reviews] review canceled: [Bug 93253] Web Inspector: renaming DOMNodeHighlighter to InspectorOverlay : [Attachment 156651] Patch

[bugzilla-daemon at webkit.org]

Andrey Kosyakov <caseq at chromium.org> has canceled Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 93253: Web Inspector: renaming DOMNodeHighlighter to InspectorOverlay
https://bugs.webkit.org/show_bug.cgi?id=93253

Attachment 156651: Patch
https://bugs.webkit.org/attachment.cgi?id=156651&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156651&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:1008
> +    if (enabled)
> +	   m_inspectModeHighlightConfig =
highlightConfigFromInspectorObject(errorString, highlightInspectorObject);

please split this into a separate change.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1019
> +	   return PassOwnPtr<HighlightConfig> ();

return nullptr?