[webkit-reviews] review denied: [Bug 93005] Web Inspector: [Elements] Implement decorations for nodes with DOM breakpoints : [Attachment 156616] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 93005: Web Inspector: [Elements] Implement decorations for nodes with DOM
breakpoints
https://bugs.webkit.org/show_bug.cgi?id=93005

Attachment 156616: Patch
https://bugs.webkit.org/attachment.cgi?id=156616&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156616&action=review


> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:63
> +	   this._updateNodeBreakpointCountCallback = callback;

You decorator should instead allow adding a listener on itself.

> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:75
> +    breakpointTypeLabels: function(node)

This should be private.

> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:364
> +WebInspector.DOMBreakpointsSidebarPane.DOMBreakpointsDecorator = function()

WebInspector.DOMBreakpointsSidebarPane.Decorator ? (to keep things short)

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:627
> +    {

Please declare interfaces as styleClass: function() { }

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1676
> +		   computeDecorationClass(decorator);

What are you trying to do here?