[webkit-reviews] review granted: [Bug 92942] Add DeviceProximityEvent interface : [Attachment 156632] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 92942: Add DeviceProximityEvent interface
https://bugs.webkit.org/show_bug.cgi?id=92942

Attachment 156632: Patch
https://bugs.webkit.org/attachment.cgi?id=156632&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156632&action=review


Looks OK.

Sorry for the iterative comments. A couple of nits in your test.

> LayoutTests/fast/dom/Proximity/create-event-deviceproximity.html:14
> +    document.getElementById('result').innerHTML = "PASS";

Nit: you could use testPassed()

> LayoutTests/fast/dom/Proximity/create-event-deviceproximity.html:24
> +    document.getElementById('result').innerHTML = "FAIL... deviceproximity
event doesn't appear to be enabled or implemented.";

Nit: you could use testFailed()