[webkit-reviews] review granted: [Bug 91632] Web Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter : [Attachment 156627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 6 02:29:11 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 91632: Web Inspector: extracting HighlightInfo from HighlightData in
DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=91632

Attachment 156627: Patch
https://bugs.webkit.org/attachment.cgi?id=156627&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156627&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:1053
> +	   if (!highlightInspectorObject) {

I think you could move this code into
highlightConfigFromInspectorObject(errorString, ...)


More information about the webkit-reviews mailing list