[webkit-reviews] review granted: [Bug 93233] [Chromium]duplicated command line options in Android LayoutTest : [Attachment 156626] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 6 02:17:15 PDT 2012
Tony Chang <tony at chromium.org> has granted Wei James (wistoch)
<james.wei at intel.com>'s request for review:
Bug 93233: [Chromium]duplicated command line options in Android LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=93233
Attachment 156626: Patch
https://bugs.webkit.org/attachment.cgi?id=156626&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156626&action=review
Seems fine, but should we add a unit test for this?
> Tools/ChangeLog:12
> + If there are multiple ChromiumAndroidPort instances, these two
options
> + will be appended for multiple times.
Do we normally have multiple ChromiumAndroidPort instances? Does having these
options multiple times cause anything to break?
More information about the webkit-reviews
mailing list