[webkit-reviews] review canceled: [Bug 91528] Web Inspector: Embeddable Web Inspector : [Attachment 156447] Patch

[bugzilla-daemon at webkit.org]

Andrey Kosyakov <caseq at chromium.org> has canceled Gabriel Peal
<gpeal at google.com>'s request for review:
Bug 91528: Web Inspector: Embeddable Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=91528

Attachment 156447: Patch
https://bugs.webkit.org/attachment.cgi?id=156447&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156447&action=review


> Source/WebCore/English.lproj/localizedStrings.js:725
> +localizedStrings["Synchronous resource load failed with XMLHttpRequest
status %d"] = "Synchronous resource load failed with XMLHttpRequest status %d";


Please update to match the error string in loadXHR()

> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:184
> +	   var xhr = new XMLHttpRequest();
> +	   xhr.open("GET", url, false);
> +	   xhr.send(null);

So why not just call loadXHR(url, false)?

> Source/WebCore/inspector/front-end/utilities.js:699
> + * @param {boolean} async

{boolean=}?

> Source/WebCore/inspector/front-end/utilities.js:700
> + * @param {function(string)} callback

ditto -- we're not using callback for sync requests.

> Source/WebCore/inspector/front-end/utilities.js:701
> + * @return {string} value

just @return {string}

> Source/WebCore/inspector/front-end/utilities.js:708
> +    function onDataReceived() 

onReadyStateChanged?

> Source/WebCore/inspector/front-end/utilities.js:710
> +	   if (xhr.readyState === 4) {

if (xhr.readyState !== XMLHttpRequest.DONE)
    return;

> Source/WebCore/inspector/front-end/utilities.js:716
> +	       WebInspector.log(WebInspector.UIString("Resource load failed
with XMLHttpRequest status %d", xhr.status));

nit: I think logging URL as well might be useful.

> Source/WebCore/inspector/front-end/utilities.js:731
> +	   WebInspector.log(WebInspector.UIString("Resource load failed with
XMLHttpRequest status %d", xhr.status));

ditto.