[webkit-reviews] review denied: [Bug 93100] Remove minimum window size for PagePopup : [Attachment 156602] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 93100: Remove minimum window size for PagePopup
https://bugs.webkit.org/show_bug.cgi?id=93100

Attachment 156602: Patch
https://bugs.webkit.org/attachment.cgi?id=156602&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156602&action=review


> Source/WebCore/page/Chrome.cpp:61
> +#if ENABLE(PAGE_POPUP)
> +#include "DOMWindowPagePopup.h"
> +#endif
> +

unnecessary change

> Source/WebCore/page/Chrome.h:44
> +    class DOMWindow;

unnecessary change

> Source/WebCore/page/ChromeClient.h:354
> +	   virtual FloatSize minimumSizeForWindow() const { return
FloatSize(100, 100); };

nit: I prefer 'minimumWindowSize'.

> Source/WebCore/page/DOMWindow.cpp:342
> +    FloatSize minimumSize = page ?
m_frame->page()->chrome()->minimumSizeForWindow() : FloatSize(100, 100);

We can call ChromeClient::minimumSizeForWindow() here.	So we don't need to
change Chrome.{cpp.h} in this patch.

> Source/WebKit/chromium/src/WebPagePopupImpl.cpp:126
> +    virtual FloatSize minimumSizeForWindow() const

Please add OVERRIDE.

> Source/WebKit/chromium/src/WebPagePopupImpl.cpp:212
> +    ASSERT(frame->existingDOMWindow());
> +    DOMWindowPagePopup::install(frame->existingDOMWindow(), m_popupClient);
> +

This change is unnecessary.