[webkit-reviews] review granted: [Bug 90631] Web Inspector: display function scope in UI : [Attachment 156437] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 5 23:16:04 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 90631: Web Inspector: display function scope in UI
https://bugs.webkit.org/show_bug.cgi?id=90631

Attachment 156437: Patch
https://bugs.webkit.org/attachment.cgi?id=156437&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156437&action=review


> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:451
> +WebInspector.ObjectPropertyTreeElement.Populate = function(treeElement,
value) {

style: Populate -> populate

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:557
> +    onattach: function()

Please remove this and next methods.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:590
> +    onattach: function()

These two methods can also be removed.


More information about the webkit-reviews mailing list