[webkit-reviews] review granted: [Bug 92883] IndexedDB: Make leveldb store integer versions and migrate old schemas : [Attachment 156223] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 92883: IndexedDB: Make leveldb store integer versions and migrate old
schemas
https://bugs.webkit.org/show_bug.cgi?id=92883

Attachment 156223: Patch
https://bugs.webkit.org/attachment.cgi?id=156223&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156223&action=review


(In reply to comment #15)
> It looks like Tony and Ojan have been reviewing these sorts of patches
recently.  Maybe they have better context than I do?

Barely, but I trust jsbell.

> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:173
> +	       ASSERT(ok);
> +	       if (!ok)
> +		   return false;

Nit: It think it's more common to put ASSERT_NOT_REACHED() before "return
false;"

> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:327
> +    ASSERT_WITH_MESSAGE(intVersion >= 0, "intVersion was %"PRId64,
intVersion);

Does PRId64 work with VS2008?  Does it work with the gcc arm compilers?  You
might want to just static_cast to an int.