[webkit-reviews] review canceled: [Bug 90054] [EFL][WK2] Make ewk_view inheritable in the WebKit2. : [Attachment 154873] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 5 05:53:06 PDT 2012


EunMi Lee <eunmi15.lee at samsung.com> has canceled EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 90054: [EFL][WK2] Make ewk_view inheritable in the WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=90054

Attachment 154873: Patch
https://bugs.webkit.org/attachment.cgi?id=154873&action=review

------- Additional Comments from EunMi Lee <eunmi15.lee at samsung.com>
I've got an advice from EFL community to make Evas_Object inheritable with
specific value.
http://sourceforge.net/mailarchive/forum.php?thread_name=CAOtL8OpdAnDSRWv2Vdn1F
%2B1b_Hm7vhKVs%3DwHLcB1rSDO3KvdEw%40mail.gmail.com&forum_name=enlightenment-dev
el

I've made patch by referencing elementary's elm_widget.
The elm_widget provides elm_widget_add() which accepts parent as a parameter,
and the widget which inherits elm_widget creates its Evas_Object using
elm_widget_add() instead of evas_object_smart_add().

In this patch, the ewk_view provides ewk_view_smart_add() API to create
Evas_Object for WebKit2 EFL,
so, the object which inherits ewk_view can use that API to create Evas_Object
and the ewk_view can get Ewk_Context using the ewk_view_smart_add()'s
parameter.

I hope this patch can be the final patch for inheritance :)


More information about the webkit-reviews mailing list