[webkit-reviews] review granted: [Bug 92824] media/video-poster-blocked-by-willsendrequest.html isn't blocking poster on willsendrequest : [Attachment 156555] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 5 01:30:28 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 92824: media/video-poster-blocked-by-willsendrequest.html isn't blocking
poster on willsendrequest
https://bugs.webkit.org/show_bug.cgi?id=92824

Attachment 156555: Patch
https://bugs.webkit.org/attachment.cgi?id=156555&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156555&action=review


> LayoutTests/media/video-poster-blocked-by-willsendrequest.html:42
> +		   // Since this is testing resource-loading being blocked,
append a unique query string to avoid cache hits from other tests.
> +		   // FIXME: it's madness that this needs to account for other
tests.
> +		   // Why isn't the cache being cleared between tests?	Looks
like port-specific DRT bugs (chromium: 93195, mac: 82976, gtk: 79760).

You may want to make this comment more concise.


More information about the webkit-reviews mailing list