[webkit-reviews] review granted: [Bug 93138] Cleanup locations of various checks in requestPlugin and loadPlugin : [Attachment 156535] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 93138: Cleanup locations of various checks in requestPlugin and loadPlugin
https://bugs.webkit.org/show_bug.cgi?id=93138

Attachment 156535: Patch
https://bugs.webkit.org/attachment.cgi?id=156535&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156535&action=review


> Source/WebCore/loader/SubframeLoader.cpp:116
> +	   if (document() && document()->securityOrigin()->isLocal() &&
!settings->isJavaEnabledForLocalFiles())

For a followup patch, I wonder if we should be getting the document from the
pluginElement.	That way we'll always find it and we can remove these null
checks.