[webkit-reviews] review requested: [Bug 89259] [CSS Exclusions] Enable shape-inside for simple rectangles : [Attachment 156528] Incorporating feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 4 03:47:22 PDT 2012


Bear Travis <betravis at adobe.com> has asked  for review:
Bug 89259: [CSS Exclusions] Enable shape-inside for simple rectangles
https://bugs.webkit.org/show_bug.cgi?id=89259

Attachment 156528: Incorporating feedback
https://bugs.webkit.org/attachment.cgi?id=156528&action=review

------- Additional Comments from Bear Travis <betravis at adobe.com>
Incorporating feedback from Julien. Largest changes are removing the shape
inside bitfield from RenderObject, and moving the hashmap to use OwnPtr instead
of raw pointers. Some wrap shapes are supported in CSS parsing but not yet in
layout, making isWrapShapeInfoEnabledForBlock a method that is currently
necessary but may not be in the future.


More information about the webkit-reviews mailing list