[webkit-reviews] review granted: [Bug 90321] Convert HTML parser to handle 8-bit resources without converting to UChar* : [Attachment 156448] Patch with performance update to r123679

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 90321: Convert HTML parser to handle 8-bit resources without converting to
UChar*
https://bugs.webkit.org/show_bug.cgi?id=90321

Attachment 156448: Patch with performance update to r123679
https://bugs.webkit.org/attachment.cgi?id=156448&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156448&action=review


Thanks for iterating on the patch.  I'm mostly forwarding Geoffrey Garen's r+,
but I read through the whole patch and it looks reasonable.  SegmentedString is
getting kind of complicated, but I think that's the price of performance here.

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:66
> +    unsigned length = string.length();

At some point we need to change all these "unsigned" types to "size_t", but
that's not a problem we should solve in this patch.