[webkit-reviews] review denied: [Bug 93158] [Chromium] Cleanup ResourceResponse cross-thread-copying. : [Attachment 156458] crossThreadCopy

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Michael Nordman
<michaeln at google.com>'s request for review:
Bug 93158: [Chromium] Cleanup ResourceResponse cross-thread-copying.
https://bugs.webkit.org/show_bug.cgi?id=93158

Attachment 156458: crossThreadCopy
https://bugs.webkit.org/attachment.cgi?id=156458&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156458&action=review


r- due to missing fix :)

> Source/WebCore/ChangeLog:5
> +	   data member is handled, an isolatedCopy() is needed for thread
safety.

I think you missed this part of the patch :)

Also is it worth while putting a ***WARNING** comment in the
(doPlatformCopyData) function to make sure copies are done? (Of course there
are several of them.) I leave it up to you.