[webkit-reviews] review granted: [Bug 93157] DFG::StructureCheckHoistingPhase keeps a Node& around for too long : [Attachment 156456] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 3 14:32:15 PDT 2012
Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 93157: DFG::StructureCheckHoistingPhase keeps a Node& around for too long
https://bugs.webkit.org/show_bug.cgi?id=93157
Attachment 156456: the patch
https://bugs.webkit.org/attachment.cgi?id=156456&action=review
------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
Maybe add a comment above the declaration of the Node warning future travelers
that they should be careful not to use it after the append? Other than that,
looks good.
More information about the webkit-reviews
mailing list