[webkit-reviews] review granted: [Bug 88427] [CSS Shaders] Reuse precompiled shaders across elements : [Attachment 153910] Patch V1

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 88427: [CSS Shaders] Reuse precompiled shaders across elements
https://bugs.webkit.org/show_bug.cgi?id=88427

Attachment 153910: Patch V1
https://bugs.webkit.org/attachment.cgi?id=153910&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153910&action=review


Cool!

> LayoutTests/css3/filters/custom/custom-filter-shader-reuse.html:26
> +	       function runTest()
> +	       {

{ on line above

> Source/WebCore/ChangeLog:10
> +	   CustomFilterGlobalContext now acts as a cache for the compiled
shaders. Note that only the shaders displayed on screen
> +	   are cached, making it useful in animations or when more elements
share the same shader filter.

maybe "only the shaders displayed on the page" because I guess a filtered
element might be scrolled off screen?

> Source/WebCore/ChangeLog:20
> +	   is allowed to be null. A null strings is the placeholder for the
default shader.

typo: strings -> string.

> Source/WebCore/platform/graphics/filters/CustomFilterCompiledProgram.h:82
> +    // Note that, CustomFilterGlobalContext doesn't not keep a strong
reference to 
> +    // the CustomFilterCompiledProgram.

typo: no comma necessary