[webkit-reviews] review requested: [Bug 90321] Convert HTML parser to handle 8-bit resources without converting to UChar* : [Attachment 156448] Patch with performance update to r123679

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 90321: Convert HTML parser to handle 8-bit resources without converting to
UChar*
https://bugs.webkit.org/show_bug.cgi?id=90321

Attachment 156448: Patch with performance update to r123679
https://bugs.webkit.org/attachment.cgi?id=156448&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
This patch eliminates the 3.59% slowdown on html-parser.html and the 2.81%
slowdown on tiny-innerHTML.html.
These are now a 2.17 progression and a -.22% regression (greater that the
StDev).

Comparison of pre-8bit changes with this patch.
The pre-8bit changes is r124244 with the 8 bit Latin-1 (r123008) and UTF8
(r123011) changesets removed.
This patch is built on r124244.

				 Pre-8bit   This patch
css-parser-yui.html	  Average   359.00    359.42  0.12%
(runs/sec)		  Median    359.67    359.90  0.06%
(Bigger is better)	  StDev       1.63	1.73
			  Min	    355.33    355.33
			  Max	    360.82    362.23
html-parser.html	  Average  1835.25   1795.45  2.17%
(ms)			  Median   1835.00   1794.00  2.23%
(Smaller is better)	  StDev       4.38	3.98
			  Min	   1827.00   1788.00
			  Max	   1844.00   1804.00
html5-full-render.html	  Average 21508     21303     0.96%
(ms)			  Median  21508     21303     0.96%
(Smaller is better)	  StDev      61        60   
			  Min	  21447     21243
			  Max	  21569     21362
innerHTML-setter.html	  Average   273.21    299.57  9.65%
(runs/sec)		  Median    273.12    299.63  9.70%
(Bigger is better)	  StDev       0.74	0.76
			  Min	    271.94    297.40
			  Max	    274.66    300.75
query-selector-deep.html  Average   392.83    387.46 -1.37%
(runs/sec)		  Median    393.12    387.41 -1.45%
(Bigger is better)	  StDev       0.93	0.92
			  Min	    390.72    385.54
			  Max	    394.09    389.29
query-selector-first.html Average  2065.49   1996.82 -3.32%
(runs/sec)		  Median   2065.85   1996.26 -3.37%
(Bigger is better)	  StDev      18.65     11.74
			  Min	   2007.53   1975.31
			  Max	   2091.50   2022.76
query-selector-last.html  Average   361.27    378.34  4.73%
(runs/sec)		  Median    361.29    378.25  4.69%
(Bigger is better)	  StDev       0.65	0.74
			  Min	    359.44    376.91
			  Max	    362.23    379.60
simple-url.html 	  Average    45.67     49.89  9.23%
(runs/sec)		  Median     45.71     49.82  8.97%
(Bigger is better)	  StDev       0.13	0.50
			  Min	     45.35     49.26
			  Max	     45.87     50.51
textarea-parsing.html	  Average    52.22     56.20  7.62%
(runs/sec)		  Median     52.29     56.31  7.69%
(Bigger is better)	  StDev       0.33	0.33
			  Min	     51.41     55.07
			  Max	     52.63     56.56
tiny-innerHTML.html	  Average     4.89	4.88 -0.22%
(runs/sec)		  Median      4.88	4.88 -0.18%
(Bigger is better)	  StDev       0.05	0.03
			  Min	      4.81	4.82
			  Max	      4.98	4.93
url-parser.html 	  Average   102.56    107.27  4.59%
(runs/sec)		  Median    102.63    104.99  2.30%
(Bigger is better)	  StDev       0.86	4.71
			  Min	    100.88    104.44
			  Max	    103.90    118.27
xml-parser.html 	  Average     7.64	7.77  1.70%
(runs/sec)		  Median      7.64	7.76  1.62%
(Bigger is better)	  StDev       0.03	0.04
			  Min	      7.56	7.70
			  Max	      7.71	7.82