[webkit-reviews] review granted: [Bug 92374] Inaccurate layoutMod : [Attachment 156310] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 92374: Inaccurate layoutMod
https://bugs.webkit.org/show_bug.cgi?id=92374

Attachment 156310: Patch
https://bugs.webkit.org/attachment.cgi?id=156310&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156310&action=review


>>> Source/WebCore/rendering/LayoutTypes.h:156
>>> +inline LayoutUnit layoutIntMod(const LayoutUnit& numerator, const
LayoutUnit& denominator)
>> 
>> I think this level of indirection should just go away and callers should
call directly into FractionalLayoutUnit's functions. LayoutTypes was created
largely to ease the transition to FractionalLayoutUnits, which has occurred.
> 
> I thought that would be done when most platforms had switched subpixel
layout, and  FractionLayoutX could be renamed LayoutX?

We would like to do this rename, but we should minimize the duplication of
functionality in LayoutTypes.h now that all platforms are using
FractionalLayoutUnits. In the meantime, this isn't a gating issue. r=me pending
results from the cr-linux bot, and provided you follow up with updated
expectations once the bots have cycled with the patch. Let me know if you need
help with that last part :)