[webkit-reviews] review granted: [Bug 45118] Update TypedArrays to throw RangeError or similar instead of INDEX_SIZE_ERR : [Attachment 156404] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 3 11:30:55 PDT 2012


Kenneth Russell <kbr at google.com> has granted arno. <arno at renevier.net>'s
request for review:
Bug 45118: Update TypedArrays to throw RangeError or similar instead of
INDEX_SIZE_ERR
https://bugs.webkit.org/show_bug.cgi?id=45118

Attachment 156404: updated patch
https://bugs.webkit.org/attachment.cgi?id=156404&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks good. Could you please make sure the tests in
http://www.khronos.org/registry/webgl/sdk/tests/conformance/typedarrays/ pass
with these changes? (I suspect they should since they don't have test
expectations like WebKit, and the majority of the code is checked in as layout
tests.) r=me


More information about the webkit-reviews mailing list