[webkit-reviews] review denied: [Bug 93111] [Chromium] Implement the find-in-page match rects API : [Attachment 156414] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 3 10:51:59 PDT 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Leandro Graciá
Gil <leandrogracia at chromium.org>'s request for review:
Bug 93111: [Chromium] Implement the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93111

Attachment 156414: Patch
https://bugs.webkit.org/attachment.cgi?id=156414&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156414&action=review


> Source/WebCore/platform/chromium/FindInPageCoordinates.cpp:50
> +static FloatRect toNormalizedRect(const FloatRect& absoluteRect, const
RenderObject* renderer, FloatRect* containerBoundingBox = 0)

code in WebCore/platform is not allowed to depend on code in WebCore/rendering


More information about the webkit-reviews mailing list