[webkit-reviews] review granted: [Bug 93110] [Chromium] Add stubs for the find-in-page match rects API : [Attachment 156365] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 3 10:13:48 PDT 2012
Adam Barth <abarth at webkit.org> has granted Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 93110: [Chromium] Add stubs for the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93110
Attachment 156365: Patch
https://bugs.webkit.org/attachment.cgi?id=156365&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156365&action=review
Thanks.
> Source/WebKit/chromium/src/WebFrameImpl.cpp:1945
> + // FIXME(leandrogracia): implement this as part of
https://bugs.webkit.org/show_bug.cgi?id=93111.
FIXME(leandrogracia) -> FIXME
WebKit doesn't use user names in FIXME comments.
implement -> Implement
We try to use English sentence punctuation in comments.
More information about the webkit-reviews
mailing list