[webkit-reviews] review denied: [Bug 91632] Web Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter : [Attachment 156393] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 3 09:30:46 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 91632: Web Inspector: extracting HighlightInfo from HighlightData in
DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=91632

Attachment 156393: Patch
https://bugs.webkit.org/attachment.cgi?id=156393&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156393&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:1009
> +	       *errorString = "Null pointer for highlightInspectorObject in
InspectorDOMAgent::setSearchingForNode";

I think I was commenting on this earlier.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1054
> +	       *errorString = "Null pointer for highlightInspectorObject in
InspectorDOMAgent::highlightNode";

ditto


More information about the webkit-reviews mailing list