[webkit-reviews] review granted: [Bug 92914] Apply target fuzzing when sending a context menu event : [Attachment 156164] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 92914: Apply target fuzzing when sending a context menu event
https://bugs.webkit.org/show_bug.cgi?id=92914

Attachment 156164: Patch
https://bugs.webkit.org/attachment.cgi?id=156164&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156164&action=review


Looks good. I have two questions left:

> Source/WebCore/page/EventHandler.cpp:2473
> +    // For now we use the adjusted position to ensure the later redundant
hit-tests hits the right node.

this comment reads  a bit strange to me.

> Source/WebCore/page/EventHandler.cpp:2661
> +    PlatformMouseEvent mouseEvent(adjustedPoint, event.globalPosition(),
RightButton, eventType, 1, false, false, false, false, WTF::currentTime());

do we care about adjusting the globalPosition as well?

>>> LayoutTests/touchadjustment/touch-links-longpress.html:38
>>> +	     if (eventSender.gestureLongPress)
>> 
>> my previous question was more:
>> 
>> is gestureLongPress support by chromium only? Qt might fail and it is
skipped,but what about mac,mac-win,gtk,efl,blackerry,etc?
> 
> I am not sure whether or not the other platforms support gestureLongPress.
But since this new test is inside of touchadjustment/ and only chromium and qt
have this directory unskipped, there should be no failures on the other
platforms.

Ok.