[webkit-reviews] review granted: [Bug 93077] [WK2] LayerTreeCoordinator can disallow tile updates in forceRepaint : [Attachment 156283] proposed fix

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 93077: [WK2] LayerTreeCoordinator can disallow tile updates in forceRepaint
https://bugs.webkit.org/show_bug.cgi?id=93077

Attachment 156283: proposed fix
https://bugs.webkit.org/attachment.cgi?id=156283&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=156283&action=review


Yep that's what I had in mind. I think it's ok to override
m_waitingForUIProcess here since forceRepaint does the same for the rest of the
layer sync operations by calling flushPendingLayerChanges directly instead of
performScheduledLayerFlush.

>
Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp
:179
> +    WTF::TemporaryChange<bool> inForceRepaint(m_inForceRepaint, true);

Wow, didn't know we had such a class.