[webkit-reviews] review denied: [Bug 93075] [V8] WebCoreStringResource should keep its StringImpl alive : [Attachment 156277] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 3 02:02:35 PDT 2012


Kentaro Hara <haraken at chromium.org> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 93075: [V8] WebCoreStringResource should keep its StringImpl alive
https://bugs.webkit.org/show_bug.cgi?id=93075

Attachment 156277: Patch
https://bugs.webkit.org/attachment.cgi?id=156277&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
Looks like this patch is wrong. Given that WebCoreStringResource::m_plainString
and WebCoreStringResource::m_atomicString are already retaining references to
their StringImpls, we don't need to add extra ref()/deref() manually.


More information about the webkit-reviews mailing list