[webkit-reviews] review denied: [Bug 93019] Web Inspector: WebInspector.linkifyStringAsFragment gives wrong typeof lineNumber : [Attachment 156144] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied johnjbarton
<johnjbarton at chromium.org>'s request for review:
Bug 93019: Web Inspector: WebInspector.linkifyStringAsFragment gives wrong
typeof lineNumber
https://bugs.webkit.org/show_bug.cgi?id=93019

Attachment 156144: Patch
https://bugs.webkit.org/attachment.cgi?id=156144&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156144&action=review


> Source/WebCore/inspector/front-end/ResourceUtils.js:-251
> -	       urlNode.lineNumber = lineNumber;

linkifier function is passed to linkifyStringAsFragmentWithCustomLinkifier as a
parameter. I think we should fix linkifyStringAsFragmentWithCustomLinkifier
instead to always pass the number to linkifier.

> LayoutTests/inspector/debugger/linkifier.html:44
> +	   var linkifyMe = "at triggerError
(http://fiddle.jshell.net/Ad2Rr/4/show/:22:11)";

nit: This real life url is distracting, I would use something like
http://localhost/:22:11 instead.