[webkit-reviews] review denied: [Bug 93069] Add keyboard support for color suggestion popup : [Attachment 156270] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 93069: Add keyboard support for color suggestion popup
https://bugs.webkit.org/show_bug.cgi?id=93069

Attachment 156270: Patch
https://bugs.webkit.org/attachment.cgi?id=156270&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156270&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests. Can't send key events to page popup.

Really?

> Source/WebCore/Resources/colorSuggestionPicker.js:80
> +//function enclosingNodeOrSelfWithClass(node, className)
> +//{
> +//	 for (var node = this; node && node !== this.ownerDocument; node =
node.parentNode) {
> +//	     if (node.nodeType === Node.ELEMENT_NODE &&
node.classList.contains(className))
> +//		 return node;
> +//	 }
> +//	 return null;
> +//}

Do not leave unused code.

> Source/WebCore/Resources/colorSuggestionPicker.js:223
> +	   switch (key) {
> +	       case "Left":

Please use the indentation same as our C++ style.