[webkit-reviews] review granted: [Bug 92927] Switch mapLocalToContainer to use a flag instead of boolean parameters : [Attachment 156161] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 92927: Switch mapLocalToContainer to use a flag instead of boolean
parameters
https://bugs.webkit.org/show_bug.cgi?id=92927

Attachment 156161: Patch
https://bugs.webkit.org/attachment.cgi?id=156161&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156161&action=review


LGTM. Just some snippets, r=me.

> Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:195
> +void RenderSVGForeignObject::mapLocalToContainer(RenderBoxModelObject*
repaintContainer, TransformState& transformState, MapLocalToContainerFlags
mode, bool* wasFixed) const
>  {
> +    UNUSED_PARAM(mode);

Sorry for not mention it before. But isn't it easier to just not use 'mode'? I
think MapLocalToContainerFlags is self descriptive.

> Source/WebCore/rendering/svg/RenderSVGInline.cpp:84
> +    UNUSED_PARAM(mode);

Ditto.

> Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:60
> +    UNUSED_PARAM(mode);

Ditto.

> Source/WebCore/rendering/svg/RenderSVGText.cpp:116
> +    UNUSED_PARAM(mode);

Ditto.