[webkit-reviews] review denied: [Bug 92942] Add DeviceProximityEvent interface : [Attachment 155985] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 92942: Add DeviceProximityEvent interface
https://bugs.webkit.org/show_bug.cgi?id=92942

Attachment 155985: Patch
https://bugs.webkit.org/attachment.cgi?id=155985&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155985&action=review


WebCore implementation looks good. Marking r- due to insufficient tests.

> Source/WebCore/ChangeLog:9
> +	   Add DeviceProximityEvent interface of Proximity Events.
> +	   And add onwebkitdeviceproximity event handler to the DOMWindow.

Please add the spec link to the ChangeLog.

> Source/WebCore/Modules/proximity/DeviceProximityEvent.h:45
> +	   return adoptRef(new DeviceProximityEvent);

Nit: new DeviceProximityEvent()

> LayoutTests/ChangeLog:8
> +	   Add a test case to create DeviceProximityEvent and to check
onwebkitdeviceproximity.

- Let's add test cases for constructor. Look at tests under
fast/events/constructors/. Let's add
fast/events/constructors/device-proximity-event.html

- Can you test if the DeviceProximityEvent bubbles up correctly?