[webkit-reviews] review granted: [Bug 93037] Remove dependency on LayoutTypes.h from transformation code : [Attachment 156211] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 93037: Remove dependency on LayoutTypes.h from transformation code
https://bugs.webkit.org/show_bug.cgi?id=93037

Attachment 156211: Patch
https://bugs.webkit.org/attachment.cgi?id=156211&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156211&action=review


> Source/WebCore/ChangeLog:16
> +	   * rendering/LayoutTypes.h:
> +	   Remove clampToLayoutUnit
> +	   

We don't usually put whitespace here, and this could just be one line.

> Source/WebCore/ChangeLog:21
> +	   Add FractionalLayoutUnit::clamp method that clamps a double to a
> +	   FractionalLayoutUnit.
> +	   

Ditto.

> Source/WebCore/ChangeLog:27
> +	   Use clamp/max/min from FractionalLayoutUnit instead of going through

> +	   LayoutUnit abstraction.
> +	   

Ditto.