[webkit-reviews] review denied: [Bug 92934] nrwt: handle errors from image diff better : [Attachment 156179] delete test code accidentally left in

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 92934: nrwt: handle errors from image diff better
https://bugs.webkit.org/show_bug.cgi?id=92934

Attachment 156179: delete test code accidentally left in
https://bugs.webkit.org/attachment.cgi?id=156179&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156179&action=review


r- just until I understand why the rmtree change makes sense. The rest LGTM.

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:230
> +		   self._filesystem.rmtree(str(tempdir))

We used to always do this and now only do it for exit_code == 1. Can you
explain why in the ChangeLog (assuming this is correct)?