[webkit-reviews] review denied: [Bug 26559] When a block's height is determined by min-height/max-height, children with percentage heights are sized incorrectly : [Attachment 155594] Bug fix

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 26559: When a block's height is determined by min-height/max-height,
children with percentage heights are sized incorrectly
https://bugs.webkit.org/show_bug.cgi?id=26559

Attachment 155594: Bug fix
https://bugs.webkit.org/attachment.cgi?id=155594&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155594&action=review


Looks roughly correct. Thanks for the fix! Please address my comment as well as
Max's.

> Source/WebCore/rendering/RenderBox.cpp:2138
>	   result =
cb->computePercentageLogicalHeight(cbstyle->logicalHeight());
> -	   if (result != -1)
> -	       result = cb->computeContentBoxLogicalHeight(result);
> +	   if (result != -1) {
> +	       result =
cb->computeContentLogicalHeightRespectingMinMaxHeight(result);
> +	       if (result != -1)
> +		   result = cb->computeContentBoxLogicalHeight(result);
> +	   }

Doesn't computePercentageLogicalHeight already adjust for min/max with your
above change?

> Source/WebCore/rendering/RenderBox.cpp:2172
> +    return result;

Can you have this call computeContentBoxLogicalHeight? Then you don't need to
do it in the two calling locations?