[webkit-reviews] review granted: [Bug 92881] HTMLMediaElement may fire the seeked event before currentTime reaches the seek time : [Attachment 155884] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 2 13:39:27 PDT 2012


Eric Carlson <eric.carlson at apple.com> has granted Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 92881: HTMLMediaElement may fire the seeked event before currentTime
reaches the seek time
https://bugs.webkit.org/show_bug.cgi?id=92881

Attachment 155884: Patch
https://bugs.webkit.org/attachment.cgi?id=155884&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155884&action=review


> LayoutTests/media/video-seek-past-end-paused.html:30
> +		   // wait 2 timeupdate events so we are sure the media engine
is
> +		   // playing the media.

Minor nit: I would prefer to have comments-as-sentences as we do in WebKit
proper. Here and throughout the file.


More information about the webkit-reviews mailing list