[webkit-reviews] review denied: [Bug 90277] Web Inspector: added Paint events for Images to TimelineAgent : [Attachment 155794] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 2 12:08:15 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has denied Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 90277: Web Inspector: added Paint events for Images to TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90277
Attachment 155794: Patch
https://bugs.webkit.org/attachment.cgi?id=155794&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155794&action=review
> LayoutTests/inspector/timeline/timeline-decode-resize-expected.txt:9
> + imageType : "PNG"
Please test every image type.
> LayoutTests/inspector/timeline/timeline-decode-resize-expected.txt:32
> +ResizeImage Properties:
Please cache cached: true and false cases.
I suspect this test is flaky: is there a guarantee you are getting exactly 2
resize events on all platforms?
More information about the webkit-reviews
mailing list