[webkit-reviews] review denied: [Bug 91632] Web Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter : [Attachment 155757] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 91632: Web Inspector: extracting HighlightInfo from HighlightData in
DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=91632

Attachment 155757: Patch
https://bugs.webkit.org/attachment.cgi?id=155757&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155757&action=review


Looks good. A couple of nits inline.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:565
> +    if (!m_highlightNode && !m_highlightRect)

I think now node and rect highlighting are independent first class citizens.
You should treat them separately (as you treat drawPausedInDebugger)

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1009
> +	       *errorString = "Null pointer for highlightInspectorObject in
InspectorDOMAgent::setSearchingForNode";

"Internal error: highlight configuration parameter is missing"