[webkit-reviews] review granted: [Bug 90269] [GTK] Add a new and reusable enchant-based spellchecker in WebCore : [Attachment 156071] Patch proposal

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 90269: [GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269

Attachment 156071: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=156071&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156071&action=review


Looks good, but I have one tiny suggestion before landing.

> Source/WebCore/platform/text/gtk/TextCheckerEnchant.cpp:165
> +	       GOwnPtr<gchar> currentLanguage(g_strdup(iter->utf8().data()));

This can just be:

CString currentLanguage = iter->utf8();

and you could avoid one memory allocation.